- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 33.3k
gh-139646: fix typo in pickletools error message #139647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    Signed-off-by: yihong0618 <zouzou0208@gmail.com>
              
                    picnixz
  
              
              approved these changes
              
                  
                    Oct 6, 2025 
                  
              
              
            
            
              
                    serhiy-storchaka
  
              
              approved these changes
              
                  
                    Oct 6, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
| Thanks @yihong0618 for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. | 
    
  miss-islington 
      pushed a commit
        to miss-islington/cpython
      that referenced
      this pull request
    
      Oct 6, 2025 
    
    
      
  
    
    
  
    
  miss-islington 
      pushed a commit
        to miss-islington/cpython
      that referenced
      this pull request
    
      Oct 6, 2025 
    
    
      
  
    
    
  
| GH-139649 is a backport of this pull request to the 3.14 branch. | 
| GH-139650 is a backport of this pull request to the 3.13 branch. | 
    
  danigm 
      pushed a commit
        to openSUSE-Python/cpython
      that referenced
      this pull request
    
      Oct 7, 2025 
    
    
      
  
    
      
    
  
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
    
  encukou 
      pushed a commit
      that referenced
      this pull request
    
      Oct 7, 2025 
    
    
      
  
    
      
    
  
…GH-139649) (cherry picked from commit 36a6c2c) Signed-off-by: yihong0618 <zouzou0208@gmail.com> Co-authored-by: yihong <zouzou0208@gmail.com>
    
  encukou 
      pushed a commit
      that referenced
      this pull request
    
      Oct 7, 2025 
    
    
      
  
    
      
    
  
…GH-139650) (cherry picked from commit 36a6c2c) Signed-off-by: yihong0618 <zouzou0208@gmail.com> Co-authored-by: yihong <zouzou0208@gmail.com>
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
as diff
add follow the rule in comments typo in error can fix